On Sat, 13 Apr 2024 22:58:31 GMT, Phil Race <[email protected]> wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add output bins support to the common print dialog > > src/java.desktop/share/classes/sun/print/ServiceDialog.java line 1333: > >> 1331: >> 1332: private MediaPanel pnlMedia; >> 1333: private OutputPanel pnlOutput; > > I've mulled this over and I'm not sure that Page Setup is where this should > appear. I suspect you considered it analogous to Source but IPP considers > input tray to be a Media. > > I don't think everything is logical about the rest of how things are divided > up/named either but I just don't see it as a Page Setup option. > > I think it might be better placed under Sides + Job Attributes on the > so-called "Appearance" tab. The OutputPanel is moved to the `Appearance` tab. > src/java.desktop/share/classes/sun/print/resources/serviceui.properties line > 32: > >> 30: border.jobattributes=Job Attributes >> 31: border.media=Media >> 32: border.output=Output > > You only updated the default file. > You MUST update all of them, even if you just use English as above. If you > don't do this and you are in (say) Germany with language set to German then > the dialog will fail like this > > Exception in thread "AWT-EventQueue-0" java.lang.Error: Fatal: Resource for > ServiceUI is broken; there is no border.output key in resource I will look how to translate the `Output` and `Output Trays` into languages used in the serviceui properties. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1586723614 PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1586722293
