On Fri, 24 May 2024 06:29:23 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit**), the menu >> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially >> and then toggles between show/hide on `ALT` press. >> Proposed fix is to handle the `ALT` key press for GTK LAF and mimic the >> native behavior. Fix is similar to the `ALT` key processing in Windows LAF. >> Automated test case is added to verify the fix and tested in Ubuntu and >> Oracle linux. >> >> CI testing is green and link attached in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > condition check update test/jdk/com/sun/java/swing/plaf/gtk/TestMenuMnemonicOnAltPress.java line 66: > 64: robot.keyPress(KeyEvent.VK_ALT); > 65: robot.waitForIdle(); > 66: robot.delay(100); would it be better to set a longer autodelay if needed and remove the extra manual delays? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1621387034
