On Thu, 30 May 2024 20:08:15 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition check update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
> line 769:
>
>> 767: */
>> 768: static void repaintMnemonicsInContainer(final Container cont) {
>> 769: for (int i = 0; i < cont.getComponentCount(); i++) {
>
> i think you can use `final Component c : cont.getComponents()` here the same
> way you did in the repaintMnemonicsInWindow method
Updated.
> test/jdk/com/sun/java/swing/plaf/gtk/TestMenuMnemonicOnAltPress.java line 66:
>
>> 64: robot.keyPress(KeyEvent.VK_ALT);
>> 65: robot.waitForIdle();
>> 66: robot.delay(100);
>
> would it be better to set a longer autodelay if needed and remove the extra
> manual delays?
Sometimes the mnemonics show/hide count was not incrementing correctly if auto
delay is set to 100 and there is no manual delay after key event.
Although setting longer autodelay (200 ms) doesn't require the explicit
robot.delay(100). Tested in CI for multiple runs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1621989018
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1621988764
