On Thu, 6 Jun 2024 07:16:42 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Alisen Chung has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Merge branch 'master' of github.com:openjdk/jdk into 8315655 >> - fix trailing whitespace in instructions string >> - fix line ender >> - fix whitespaces and newline >> - fix whitespaces and newline >> - init commit > > I guess it needs to be understood why it is not failing in windows and linux > and only reproducible in macos. The fix in BasicLookAndFeel is not > appropriate in my opinion as that shared code will be exercised in windows > and linux too.. > > I guess we need to find out why `BasicLookAndFeel.evenDIspatched` is called > for MOUSE_PRESSED in macos and not in windows/linux (ie only called for > MOUSE_RELEASED event), maybe something needs to be done in macos JDK native > event processing to ensure it is only called for "mouse release" event for > showing popup. > > Also, the test can be automated as it is about popup being shown or not which > can be easily checked by `isPopupMenuVIsible/isVisible` method @prsadhuk I've updated the fix to only affect macOS code. I changed NSEvent isPopupTrigger to check for MOUSE_PRESSED or MOUSE_RELEASED java events. Please take a look ------------- PR Comment: https://git.openjdk.org/jdk/pull/19569#issuecomment-2152906675
