On Thu, 6 Jun 2024 16:08:31 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering the popup
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add event check in popup trigger
Don't forget to update the years for the copyrights at the top of each file
changed.
src/java.desktop/macosx/classes/sun/lwawt/macosx/NSEvent.java line 276:
> 274: && jeventType != MouseEvent.MOUSE_RELEASED) {
> 275: return false;
> 276: }
Just to double check, are the only jeventTypes to trigger popups using mouse?
Could there be other event types, maybe using keyboard for example with
tab/arrows & enter?
-------------
PR Review: https://git.openjdk.org/jdk/pull/19569#pullrequestreview-2102841943
PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1630012827
