On Fri, 7 Jun 2024 23:14:47 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test based on feedback
>
> test/jdk/javax/swing/JPopupMenu/MouseDragPopupTest.java line 59:
>
>> 57: });
>> 58: robot.waitForIdle();
>> 59: robot.delay(1000);
>
> Suggestion:
>
> robot.setAutoDelay(100);
> robot.setAutoWaitForIdle(true);
>
> SwingUtilities.invokeAndWait(() -> {
> createAndShowGUI();
> });
> robot.delay(1000);
>
>
> I was able to remove all the individual `waitForIdle()` calls and replaced it
> with `setAutoWaitForIdle()`. Still seemed to work fine on macOS.
Most tests i've looked at aren't using setAutoWaitForIdle(). Are there any
issues with test stability?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1631797841
