On Mon, 10 Jun 2024 20:01:47 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or >> windows. >> The solution is to add a check for a mouse pressed event to show popup and >> prevent mouse entered events from triggering the popup > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > updated test, removed robot waitForIdles, jtreg summary, release in finally Marked as reviewed by psadhukhan (Reviewer). test/jdk/javax/swing/JPopupMenu/MouseDragPopupTest.java line 39: > 37: * @test > 38: * @bug 8315655 > 39: * @summary Right click and dragging over a component with a popup menu > will open the popup Actually summary should be what test is expected to do like "Verifies Right click and dragging over a component with a popup menu will not open the popup" test/jdk/javax/swing/JPopupMenu/MouseDragPopupTest.java line 49: > 47: static Robot robot; > 48: static volatile Point srcPoint; > 49: static volatile Dimension d; better to club all volatile vars one after another.. ------------- PR Review: https://git.openjdk.org/jdk/pull/19569#pullrequestreview-2109410215 PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1634246763 PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1634248178
