On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Revert updated translation
>
> Did not look at each for translation accuracy (did some for Japanese), but 
> looks good overall.
> It's great to see diffs in native languages, rather than those cryptic 
> `\uXXXX` notation!

An interesting note after looking at Phil's comment on the serviceui.properties 
change is that there is no Japanese update for that file. The translations on 
[here](https://github.com/openjdk/jdk/commit/c7d2a5c1c4e86955100f4c40170dc25222abd07f#diff-38c26a463e174224c6b9fc5007f3058482e533dc0f60f3275e21f9f2fc9acf8e)
 from the output bins update look good to me but maybe @naotoj should double 
check in case?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2161748245

Reply via email to