On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar <[email protected]> wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
>> and then toggles between show/hide on `ALT` press.
>> Proposed fix is to handle the `ALT` key press for GTK LAF and mimic the
>> native behavior. Fix is similar to the `ALT` key processing in Windows LAF.
>> Automated test case is added to verify the fix and tested in Ubuntu and
>> Oracle linux.
>>
>> CI testing is green and link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> condition update
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
line 1063:
> 1061: } else {
> 1062: isMnemonicHidden = hide;
> 1063: }
Can we use or even re-use the logic in Windows L&F to display and hide menu
mnemonics?
Is this fix limited to menu mnemonics? Does it apply to all mnemonics in
components?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1644753520
