On Thu, 20 Jun 2024 10:39:48 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Yes, it could have been done that way and my intiial fix in JBS is that only >> but I wanted to reinstate the flag as it is before >> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) which was working >> till now.. > > The only problem with the flag is that the data flow is not as clear. > > I'm not insisting, it worked before and it will work in the future. The way it was "before" is that we always returned the value of "doIt". Why not restore that for consistency ? >> We can have a followup bug on this I guess since it was existing before >> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) also.. > > All I wanted is to bring up the inconsistency so that a few people would take > a look at it while reviewing this change. It does look odd. Focus would need transferring in both cases I'd expect. It goes back to the very beginning of open source JDK so I can't see a changeset to point to in order to explain it. And I also can't find any bug reports that might be related - either one about adding it, or one about things not working because it is not always executed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19786#discussion_r1648070159 PR Review Comment: https://git.openjdk.org/jdk/pull/19786#discussion_r1648068766
