On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:

> If you're currently reviewing this PR, thank you!
> Most fixes here are according to the reports by the since checker tool in 
> #18934 and are pretty simple.
> 
> To make reviewing easier
> - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a 
> long time so the default constructor (without parameters) didn't exist until 
> JDK 16
> 
> For the `package-info` files, it is pretty hard to find source code of JDK 
> 1-5 so I used the `grep` command to find the oldest instance of an `@since` 
> in those packages.
> 
> I found instances of `@since 1.1` in the other packages but 
> `javax/swing/plaf/synth/package-info.java` might be worth checking as most 
> classes there had no `@since`.

This pull request has now been integrated.

Changeset: 8591eff7
Author:    Nizar Benalla <nbena...@openjdk.org>
Committer: Alexey Ivanov <aiva...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/8591eff78dbc9770b8d0a16e05040ac35c99881a
Stats:     42 lines in 9 files changed: 34 ins; 0 del; 8 mod

8332103: since-checker - Add missing @ since tags to java.desktop

Reviewed-by: tr, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/19192

Reply via email to