On Wed, 17 Jul 2024 04:44:47 GMT, Abhishek Kumar <[email protected]> wrote:
> > Are there no repercussions to setting this boolean to `TRUE` across the > > board for one test to pass? > > I guess my question is, why was it explicitly set to FALSE before and now > > we set it to TRUE? > > Why was it set to `FALSE` before is unclear to me but if you see the code > where the value is being retrieved in [BasicColorChooserUI](url), it > fallbacks to `TRUE` if the property is not defined (Code was added as an > initial load, no modification after that). That is the case in other LAFs > where it is not defined and hence the "Preview" title is visible. So, I think > it should be `TRUE` for GTK as well as we do have a `Preview` panel in UI. Did you link to the correct thing for the BasicColorChooserUI hyperlink? I get linked to a `URL.set` issue. I'd want to see where just to be able to double-check myself if this value is used anywhere else. > > > Is there a native example? And is this a harmless change? > > I couldn't find any native app as such but there are no tests which failed > due to this change. Seems like a fair change then. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20104#issuecomment-2237121794
