On Wed, 10 Jul 2024 05:56:17 GMT, Abhishek Kumar <[email protected]> wrote:
> This test was modified under > [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the > applet usage. Test modification includes the instruction change as well which > says that `Check that there is a panel with "Text Preview Panel" text and > with title "Preview" in the JColorChooser`. Applet test didn't say explicitly > about the panel title. > > When the test is run with `GTKLookAndFeel` option, `Preview` title is missing > due to the `showPreviewPanelText` property defined for `GTKLookAndFeel` is > set to **FALSE**. `showPreviewPanelText` property is not defined for other > L&Fs and that leads to fallback to the default value of **TRUE** for the > property while lookup. > > Proposed fix is to change the default value of `showPreviewPanelText` > property to **TRUE** for GTK L&F. src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java line 551: > 549: > 550: > 551: "ColorChooser.showPreviewPanelText", Boolean.TRUE, Is there any preview panel in GTK native app? If you could not find anything in native, then let's keep it as false and make the test prevent from running for GTK L&F.. It's like SplitPane.supportsOneTouchButton property which is false for gtk and we restrict running for GTK L&F... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20104#discussion_r1687663661
