On Fri, 2 Aug 2024 09:07:47 GMT, Tejesh R <[email protected]> wrote:
> The check mark had been transformed with default scale which is 1.0 and the
> same is used on click of checkbox. This was done while computing the layout
> and not updated while paint. Hence the scaling update is done on painting the
> check mark and CI testing is green after the update too.
The fix looks good. I ran the reproducer and the test passed without the fix
too (on external monitor). Maybe the test condition can be tweaked.
test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 74:
> 72: for (int i = 0; i < imageAfterChecked.getHeight(); i++) {
> 73: for (int j = 0; j < imageAfterChecked.getWidth();
> j++) {
> 74: if (sampleRGB != imageAfterChecked.getRGB(i, j)) {
Maybe check for the tick color (black) within the checkbox?
-------------
Changes requested by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20441#pullrequestreview-2216417294
PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1702331172
