On Mon, 5 Aug 2024 10:27:17 GMT, Jayathirth D V <[email protected]> wrote:
>> Tejesh R has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Color updation
>> - Test condition updated + Copyright year
>
> test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 86:
>
>> 84: if (!checkmarkFound) {
>> 85: try {
>> 86: ImageIO.write(imageAfterChecked, "png",
>
> Do we need to write this 8*8 image when this test fails? How useful will it
> be?
> This looks like a very simply scenario where the tests will fail if nothing
> is filled in the checkbox.
>
> May be we can write whole checkbox/Frame into an image, but then also i don't
> see how this failure image will be helpful for debugging. If possible we
> should avoid writing into an image.
I'll be used on intermittent failure cases, yeah probably writing whole
checkbox/frame will be useful. Anyhow we can add on failure cases whenever
required too. Will remove it as of now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1704028983
