On Wed, 28 Aug 2024 16:42:57 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reattach thread if AWT is the owner of NSApplication > > src/java.desktop/macosx/native/libosxapp/ThreadUtilities.m line 34: > >> 32: // The following must be named "jvm", as there are extern references to >> it in AWT >> 33: JavaVM *jvm = NULL; >> 34: static BOOL isNSApplicationOwner = YES; > > One possible suggestion would be to flip the default to `NO`, so as not to > cache the env until we know we are the owner. Flipped the default to NO.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20688#discussion_r1735632039
