On Fri, 25 Oct 2024 15:01:49 GMT, Naveen Narayanan <[email protected]> wrote:
>> This testcase checks for the following:
>>
>> 1. An image is drawn on the screen and a portion of it is captured using a
>> Robot. It is tested by comparing whether the captured image is same as the
>> source image.
>>
>> Testing:
>> Tested using Mach5(20 times per platform) in MacOS, Linux and Windows. Seen
>> all tests passing.
>
> Naveen Narayanan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8342098: Updated review comments
test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 55:
> 53: private static final int IMAGE_WIDTH = 200;
> 54: private static final int IMAGE_HEIGHT = 100;
> 55: private static volatile Point point;
Suggestion:
private static final int IMAGE_WIDTH = 200;
private static final int IMAGE_HEIGHT = 100;
private static Frame frame;
private static Canvas canvas;
private static BufferedImage realImage;
private static volatile Point point;
Re-arrange fields / variables and split them into several blocks.
Why does `canvas` still have the `volatile` modifier?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1822789646
