On Fri, 25 Oct 2024 15:01:49 GMT, Naveen Narayanan <[email protected]> wrote:
>> This testcase checks for the following:
>>
>> 1. An image is drawn on the screen and a portion of it is captured using a
>> Robot. It is tested by comparing whether the captured image is same as the
>> source image.
>>
>> Testing:
>> Tested using Mach5(20 times per platform) in MacOS, Linux and Windows. Seen
>> all tests passing.
>
> Naveen Narayanan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8342098: Updated review comments
test/jdk/java/awt/Robot/ScreenCaptureRobotTest.java line 122:
> 120: if (imgWidth != IMAGE_WIDTH || imgHeight != IMAGE_HEIGHT) {
> 121: System.out
> 122: .println("Captured and real images are different in
> size");
Suggestion:
System.out.println("Captured and real images are different in
size");
Please, don't wrap calls to `println` like this, instead wrap the message if
required.
In this case, wrapping is unnecessary. The line is 81-column long, wrapping it
doesn't improve the code readability, quite the opposite.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1822863811
