On Tue, 19 Nov 2024 17:37:16 GMT, Phil Race <[email protected]> wrote:
>> Remove doPrivileged calls from javax.imageio, javax.print and some sound
>> impl classes
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8344064
src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java
line 2042:
> 2040: private static boolean isLinkedProfileAllowed() {
> 2041: if (isLinkedProfileAllowed == null) {
> 2042: isLinkedProfileAllowed =
> Boolean.getBoolean("sun.imageio.bmp.enableLinkedProfiles");
Do we even need that static variable? Why not just
`return Boolean.getBoolean("sun.imageio.bmp.enableLinkedProfiles");`
Performance? Does it deserve an internal caching? Just curious.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22186#discussion_r1849096087
