On Tue, 19 Nov 2024 17:37:16 GMT, Phil Race <[email protected]> wrote:

>> Remove doPrivileged calls from javax.imageio, javax.print and some sound 
>> impl classes
>
> Phil Race has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8344064

src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java line 
635:

> 633:     }
> 634: 
> 635:    static interface RunnableAction<T> {

Can we use `java.util.function.Supplier`  instead?

src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java line 
801:

> 799:                             }
> 800:                             return null;
> 801:                         }).run();

Let's unwrap this `RunnableAction` and put code directly in the 
`getDefaultSoundbank`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22186#discussion_r1848798744
PR Review Comment: https://git.openjdk.org/jdk/pull/22186#discussion_r1848800902

Reply via email to