On Wed, 29 Jan 2025 02:59:03 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is
>> shown without radiobutton in WIndowsLookAndFeel as there was no provision of
>> drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing
>> the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> formatting
src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java
line 888:
> 886: }
> 887: if (icon != null) {
> 888: if (!((AbstractButton)c).isSelected()) {
Suggestion:
if (!((AbstractButton) c).isSelected()) {
test/jdk/javax/swing/JMenuItem/TestImageIconWithJRadioButtonMenuItem.java line
45:
> 43: public class TestImageIconWithJRadioButtonMenuItem {
> 44:
> 45: private static final String instructionsText = """
Suggestion:
private static final String INSTRUCTIONSTEXT = """
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1935142368
PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1935144748
