On Tue, 4 Feb 2025 11:09:35 GMT, Alexey Ivanov <[email protected]> wrote:
>> test/jdk/javax/swing/JMenuItem/TestImageIconWithJRadioButtonMenuItem.java
>> line 45:
>>
>>> 43: public class TestImageIconWithJRadioButtonMenuItem {
>>> 44:
>>> 45: private static final String instructionsText = """
>>
>> Suggestion:
>>
>> private static final String INSTRUCTIONSTEXT = """
>
> For what it's worth, it should be `INSTRUCTIONS_TEXT` with the underscore
> separating words.
>
> It's not required to capitalise private constants, only public constants use
> all capitals with underscores between words.
FWIW, it is changed to "INSTRUCTIONS" in test..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1940981255
