On Thu, 29 May 2025 16:36:47 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Matthias Bläsing has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add crash reproducer as jtreg test
>
> src/java.desktop/windows/classes/sun/awt/windows/WClipboard.java line 189:
>
>> 187: checkChange(formats);
>> 188: } catch (Throwable ex) {
>> 189:
>> System.getLogger(WClipboard.class.getName()).log(Level.WARNING, "Failed to
>> process handleContentsChanged", ex);
>
> I'm not saying not to necessarily change this, but what are we hoping to see
> with logging this warning here?
The idea here is to not silently swallow exceptions. This code is called from
`AwtToolkit::WndProc`, which from my reading will not report
exceptions/throwables. Pushing the exception to the system logger gives a
chance to detect problems here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24614#discussion_r2114399911
