On Mon, 2 Jun 2025 22:25:14 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:

>> The idea here is to not silently swallow exceptions. This code is called 
>> from `AwtToolkit::WndProc`, which from my reading will not report 
>> exceptions/throwables. Pushing the exception to the system logger gives a 
>> chance to detect problems here.
>
> Sounds reasonable but loggers don't seem to be used in `src` files as far as 
> I can tell. They are used in tests to help detect issues as you mentioned, 
> and I can find plenty of occurrences of loggers used in the `test` directory 
> of the open JDK but I don't see any in `src`. Makes me think there's an 
> alternative way to handle this.

I dropped the log level to `DEBUG` that way in normal operation this will not 
visible (and shut not affect performance). I think this might be a way to 
address the concern.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24614#discussion_r2124867413

Reply via email to