> Make sure AquaTextPasswordFieldUI can't use selectWordAction. > > The core problem here was we could call selectWordAction in the Aqua LAF on a > JPasswordField. This problem was already solved in the BasicPasswordFieldUI, > but the AquaTextPasswordFieldUI (and SynthPasswordFieldUI) do NOT extend the > BasicPasswordFieldUI, so they weren't inheriting this solution. > > So the problem is partially about multiple inheritance. > > My first response at solving the problem is just to move the existing > solution to the parent BasicTextUI class and use an instanceof to make sure > it is only applied to JPasswordFields. > > There may be many different philosophies/recommendations on how to resolve > this; I'm open to suggestions.
Jeremy Wood has updated the pull request incrementally with two additional commits since the last revision: - 8354646: move to /plaf/basic/ dir If this is longer focusing on Aqua then probably this should live in a directory focusing on BasicL&F This is partially in response to: https://github.com/openjdk/jdk/pull/25443#pullrequestreview-2880829112 - 8354646: remove os.family=="mac" This is in response to: https://github.com/openjdk/jdk/pull/25443#pullrequestreview-2880829112 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25443/files - new: https://git.openjdk.org/jdk/pull/25443/files/bdbd51b0..a7709b7e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25443&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25443&range=01-02 Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/25443.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25443/head:pull/25443 PR: https://git.openjdk.org/jdk/pull/25443
