On Mon, 2 Jun 2025 17:26:23 GMT, Jeremy Wood <d...@openjdk.org> wrote:
> > Does the accompanying testcase fails in Synth/Nimbus L&F, it seems not? > > No. I double-checked: A. If I explicitly set the L&F to Nimbus: this test > does fail in this PR, and it does not fail in master. B. The > SynthPasswordFieldUI descends from BasicTextUI, so it should not be impacted > by this PR. Since you mentioned at the beginning that` AquaTextPasswordFieldUI (and SynthPasswordFieldUI) do NOT extend the BasicPasswordFieldUI, so they weren't inheriting this solution`. so I assumed the regression testcase should fail in Aqua and Nimbus wiithout your fix but it fails in Aqua and not in Nimbus so I asked. It seems you have modified your initial PR description to NOT include Synth now so it means the problem exists only in Aqua L&F in JDK mainline, am i correct? > > Also, it will be useful to extend the test case to test all installed L&F > since it it changing Basic L&F code? > > I'm not sure what you're asking here. I meant the present regression testcase only tests the system L&F of the platform it is run ie Metal in WIndows, Linux and Aqua in Mac and does not test all L&Fs like Nimbus, Motif, WIndows, GTK so you should check for `UIManager.getInstalledLookAndFeels() `and iterate and test all the installed L&Fs of the current platform..You will find many such example of the L&F testing in `test/javax/swing` folder ------------- PR Comment: https://git.openjdk.org/jdk/pull/25443#issuecomment-2933556752
