On Sun, 1 Jun 2025 19:49:57 GMT, Phil Race <p...@openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Correct the title of the test frames
>
> test/jdk/javax/swing/JFileChooser/HTMLFileName.java line 58:
> 
>> 56:                 The first file in the list has the following name:
>> 57:                 <code>&lt;html&gt;&lt;h1 color=#ff00ff&gt;&lt;font
>> 58:                 face="Comic Sans MS"&gt;Swing Rocks!</code>
> 
> I almost said this last time, but I think the instructions should use a 
> different font name.
> On linux this will always just fall back to Dialog because this font doesn't 
> exist.
> Better to just use "Serif".

It's still clearly visible, because it uses a larger font and magenta color.

I updated to "Serif" which makes it stand out even more.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25455#discussion_r2124453666

Reply via email to