On Tue, 3 Jun 2025 07:15:53 GMT, Tejesh R <t...@openjdk.org> wrote: >> Alexey Ivanov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct the title of the test frames > > test/jdk/javax/swing/JFileChooser/HTMLFileName.java line 56: > >> 54: <ol> >> 55: <li><code>JFileChooser</code> shows a virtual directory. >> 56: The first file in the list has the following name: > > Here, we should mention that the directory name and first file name is ``` > <html><h1 color=#ff00ff><font > face="Comic Sans MS">Swing Rocks! > ```. > The directory name helps us to verify the name on `combobox` area in some L&F > (Like aqua) and file name helps us to verify in `filepane` (In some L&F).
There are no directories — you can't navigate this virtual file system. Since the `VirtualFileSystemView` returns the same files in its `getRoots`, the same files are displayed in the navigation combo box. > Should the file name be within `<code>` tag or just `""` ? Yes, it should. It's a typographic standard to render class names, keywords, file names in a monospaced font. That's how the file name is rendered in HTML. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25455#discussion_r2124406379 PR Review Comment: https://git.openjdk.org/jdk/pull/25455#discussion_r2124409180
