On Mon, 9 Jun 2025 20:50:24 GMT, Phil Race <p...@openjdk.org> wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/SwingUtilities3.java line
>> 108:
>>
>>> 106: * Checks if vsync painting is requested for {@code rootContainer}
>>> 107: *
>>> 108: * @param rootContainer topmost container. Should be Window
>>
>> Suggestion:
>>
>> * @param rootContainer topmost container. Should be {@code Window}
>
> This isn't public API doc, so I'm not inclined to go updating it any more
> than I have to.
You have kept `@code` for
[`setVsyncRequested`](https://github.com/openjdk/jdk/pull/25698/files/604d78c9e465abe6853f97b328a0c6f13c276a53#diff-52524c1d4891d53a8f9acc07e5e266ea7a07ee5ac3f84c41c240c26409719453R91);
for consistency `isVsyncRequested` should have `{@code Window}` too.
>> src/java.desktop/share/classes/java/awt/Component.java line 3938:
>>
>>> 3936: /**
>>> 3937: * Inner class for flipping buffers on a component. That
>>> component must
>>> 3938: * be a {@code Canvas} or {@code Window}
>>
>> Suggestion:
>>
>> * be a {@code Canvas} or {@code Window}.
>>
>> It ended with a full stop, and the full stop should be preserved.
>
> added back
Still missing here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2137673477
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2137677189
