On Mon, 9 Jun 2025 21:03:55 GMT, Phil Race <p...@openjdk.org> wrote:

>> src/java.desktop/share/classes/java/awt/Dialog.java line 174:
>> 
>>> 172:          * from the same toolkit except those from its own child 
>>> hierarchy.
>>> 173:          */
>>> 174:         TOOLKIT_MODAL
>> 
>> Should we add a note that `APPLICATION_MODAL` and `TOOLKIT_MODAL` mean the 
>> same thing in the absence of applets or even remove one of them?
>
> Yes, It didn't escape me that they mean essentially the same thing, even more 
> so than they did before
> Theoretically there can be more than one toolkit, although it is not really 
> possible.
> 
> Addressing the nuances of that is outside the scope of this change, so I made 
> the minimum doc change and removing applet isn't the right time to add advice 
> about which to use. So future work there.
> And very unlikely to remove either of them as I suspect the similarities mean 
> that developers probably are 50:50 in which they used, so we'd just break 
> (more) apps if we did.

A bug to clarify the usage 
[JDK-8359499](https://bugs.openjdk.org/browse/JDK-8359499): _Clarify spec 
around `TOOLKIT_MODAL` and `APPLICATION_MODAL`_.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2154776375

Reply via email to