On Tue, 10 Jun 2025 21:33:22 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> The following files still reference the now-removed applet classes and will > fail to compile. Are they not included in any tier testing? > > ``` > test/hotspot/jtreg/vmTestbase/jit/misctests/fpustack/GraphApplet.java > test/hotspot/jtreg/vmTestbase/jit/misctests/fpustack/GraphPanel.java > test/hotspot/jtreg/vmTestbase/jit/misctests/fpustack/layout.java I didn't notice those. It can't be run by any standard task. TEST.groups has it under # Just-In-Time compiler tests vmTestbase_vm_compiler = \ vmTestbase/vm/compiler \ vmTestbase/jit \ vmTestbase/vm/jit but I can't find anything that runs vmTestbase_vm_compiler Also it is HEADFUL and no hotspot tests run today in such a mode. So I am sure it isn't run on a regular basis. I'll file a hotspot bug on this, but first I'll ask if anyone knows about it. > test/jdk/java/beans/Performance/TestIntrospector.java That was on "my list" at some point - I lost it ! I will update it. > ``` > > The following javadoc tests reference the java.applet package. I don't know > whether or not this will cause test failures: > > ``` > test/langtools/jdk/javadoc/doclet/JavascriptWinTitle/package-list > test/langtools/jdk/javadoc/doclet/testLinkOption/jdk/package-list > test/langtools/jdk/javadoc/doclet/testModules/jdk/element-list These tests are run in tier1. They don't really use the applet api. They just have some data in the test directory that they work on that lists java.applet as a package name. The tests pass so I don't think I need to do anything, but it is probably still worth filing a bug to see if the owners want to remove applet from the package-list > ``` > > The following refer to applets in API documentation, so you might consider > updating the docs: > > ``` > src/java.desktop/share/classes/java/awt/doc-files/FocusSpec.html > src/java.desktop/share/classes/java/awt/doc-files/Modality.html Will do. > ``` > > In addition, I found several references to applets in comments. Many / most > of these seem OK, but you might want to look at a few to see if you think > they might worth modifying. The last two in particular might be good > candidates for renaming, although that is just cosmetic at this point: > > ``` > src/demo/share/jfc/J2Ddemo/java2d/RunWindow.java > src/demo/share/jfc/J2Ddemo/java2d/Tools.java > src/demo/share/jfc/SwingSet2/SwingSet2.java > src/java.desktop/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java > test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.java > test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java > ``` I know about the last 3 and left them. The demos previously had applet options removed. Some comments must have been missed I will update. > One more use of java/applet that should be looked at is in > `src/jdk.compiler/share/data/symbols/include.list` although I don't know > whether that matters. I saw that one. It wasn't clear to me how it was used, and since I didn't see any test failures I left it. Another one to file a component team bug about. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25698#issuecomment-2960752780 PR Comment: https://git.openjdk.org/jdk/pull/25698#issuecomment-2960755451
