On Mon, 26 May 2025 17:00:15 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
> The instructions for the `javax/swing/JFileChooser/HTMLFileName.java` test > are still not as clear. > > The file name in the instructions is rendered as HTML, which, I believe, is > unexpected. It should be displayed as the plain text. > > The instructions also say about file and directory which have HTML in their > name; this was true in the initial version of the test in #24439 that created > files and directories on the real file system. > > The final version of test uses a virtual file system that displays *three > files*, there's no way to navigate. > > I also clarified the instructions: look at how the file name of the first > file is rendered in _the file pane_ and _the navigation combo box_ (**Look > in** in Metal L&F). > > In the `VirtualFileSystemView` class, I changed the name of the third file > from `virtualFolder` to `virtualFile2.log`, and made the file array a field > which ensures `getRoots` and `getFiles` return the same list. > > > In addition to this, I reduced the number of rows allocated for the > instructions. Since the instructions are in HTML format, the number of lines > of HTML code makes no sense for determining the size. This pull request has now been integrated. Changeset: 53a83d15 Author: Alexey Ivanov <aiva...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/53a83d15a1b5686ed0f2aeb3d30cd46b73f80733 Stats: 48 lines in 1 file changed: 19 ins; 10 del; 19 mod 8357799: Improve instructions for JFileChooser/HTMLFileName.java Reviewed-by: honkar, tr, kizune ------------- PR: https://git.openjdk.org/jdk/pull/25455
