On Wed, 18 Jun 2025 05:14:08 GMT, Tejesh R <t...@openjdk.org> wrote:

>> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording 
>> "Due to an unfortunate set of historical events this method is 
>> inappropriately named".
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line 
> 1034:
> 
>> 1032:      * Gets the allocation to give the root View.
>> 1033:      * The Rectangle returned has nothing to do with visibility but
>> 1034:      * the method is thus named to preserve backward compatibility.
> 
> Suggestion:
> 
>      * the method name is preserved for backward compatibility.
> 
> If method name is retained from past then this sentence would be right ?

I agree. The above rephrasing sounds clearer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25850#discussion_r2155265661

Reply via email to