On Tue, 17 Jun 2025 12:43:23 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording
> "Due to an unfortunate set of historical events this method is
> inappropriately named".
Changes requested by aivanov (Reviewer).
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line
1032:
> 1030:
> 1031: /**
> 1032: * Gets the allocation to give the root View.
Suggestion:
* Gets the allocation for the root view.
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line
1033:
> 1031: /**
> 1032: * Gets the allocation to give the root View.
> 1033: * The Rectangle returned has nothing to do with visibility but
Suggestion:
* The rectangle returned has nothing to do with visibility but
I suggest going lower case unless you specifically refer to the rectangle as
the type in which case, it should be `{@code Rectangle}`.
-------------
PR Review: https://git.openjdk.org/jdk/pull/25850#pullrequestreview-2940543621
PR Review Comment: https://git.openjdk.org/jdk/pull/25850#discussion_r2155421060
PR Review Comment: https://git.openjdk.org/jdk/pull/25850#discussion_r2155423236
