On Thu, 26 Jun 2025 12:17:52 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is >> shown without radiobutton in WIndowsLookAndFeel as there was no provision of >> drawing the radiobutton alongside icon. >> If icon is not there, the radiobutton is drawn. Added provision of drawing >> the radiobutton windows Skin even when imageIcon is present. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > MenuItem with icon fix As I mentioned accelerators column in my previous comment, I realised that I hadn't tested accelerators so far. Indeed, accelerators rendering is broken now:  This proves that the layout isn't right. You're trying to fit both check mark / bullet and an icon into the same allocated space by moving text to the right *without reserving additional width for the icon*. At the same time, you move the check mark / bullet to the left. Such approach doesn't respect the default insets added on the left and right of a menu item. The popup menu has to become wider if both check marks / bullets and icons are rendered at the same time. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-3008665338
