On Fri, 4 Jul 2025 13:17:43 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> I guess the positioning with latest PR today should be ok >> >>  > > No, it still doesn't match the style and margins that we see in Windows File > Explorer. > > The latest fix doesn't change much, *the width of the menu hasn't changed*: > you just move the elements around trying to fit more into the same space, > which unavoidably reduces margins between elements. > > The margin between the check mark / bullet and the icon should be larger, > that popup menu in Windows File Explorer has 35 pixel-margin between the > check mark and the icon, the latest version of the fix in this review has > only 7 pixels. > > The width allocated for the popup menu has to increase where both check marks > / bullets and icons need to be rendered. Compare the screenshots of File Explorer and Swing to [own comment](https://github.com/openjdk/jdk/pull/23324#issuecomment-2705406453). There's so much “air” in File Explorer version of the popup menu. Yes, the location of the elements in Swing has changed since that time, but it can't match that in File Explorer. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2185371866
