On Mon, 30 Jun 2025 17:07:01 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> My point is to investigate the difference between clipScale and clipRound to >> ensure the correct one is used. There was a complex discussion before about >> similar issue, which is why we currently have two separate versions of this >> rounding logic. Simply replacing one with the other might not work and some >> other tweaks should be done. > > My point is `clipRound` works good in this use case, *it resolves the > problem*, I see no reason not to accept the fix. > > --- > > I agree with your general concern that we should understand better the > purpose of each method. Yet no one seems to remember the outcome of that > complex discussion, therefore switching to `clipScale` could be postponed; if > it's deemed necessary, we can easily change the method, both in the > implementation and in the test. > > I submitted [JDK-8361095](https://bugs.openjdk.org/browse/JDK-8361095) to > ensure this current discussion isn't forgotten and we figure out the purpose > and guidelines for `clipScale` and `clipRound`. Ok sounds good. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26025#discussion_r2178841430
