On Thu, 3 Jul 2025 19:59:26 GMT, Eric Caspole <ecasp...@openjdk.org> wrote:
>> src/demo/share/java2d/J2DBench/build.xml line 42: >> >>> 40: <property name="resources" location="resources"/> >>> 41: >>> 42: <condition property="source" value="8"> >> >> This would be inconsistent with the Make target. It doesn't seem right to >> update just the ant-based target. > > Yes I realized that yesterday, I never actually looked at or used the > Makefile before. I will update the Makefile so it least this PR in its own > right is consistent, regardless of these other discussion points. I think we can just drop ant and leave the makefile as it is. The source/target settings are set to that low level to indicate that the source code should be compatible with older versions of the JDK. Currently, JDK 1.4 compatibility is still maintained. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26077#discussion_r2183757974
