On Fri, 4 Jul 2025 00:59:01 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>>> I think we can just drop ant and leave the makefile as it is. The >>> source/target settings are set to that low level to indicate that the >>> source code should be compatible with older versions of the JDK. Currently, >>> JDK 1.4 compatibility is still maintained. >> >> I have supposed that this PR exists because Eric wants to use ant. Eric ? >> >> I think for today's mainline, not supporting jdk7 as an out of the box >> target isn't a huge problem. >> Current javac doesn't support 7 as a target so it seems reasonable to me. > >> Current javac doesn't support 7 as a target so it seems reasonable to me. > > That's why the makefile was parameterized, to easily set the target and > source options based on the currently used minimal supported version of > javac. But we may change it with a comment that 1.4 still should be > supported, or something like that. Yes when I need to work on J2DBench I usually use the ant and nbproject because I still often use NetBeans. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26077#discussion_r2195313649