On Mon, 7 Jul 2025 15:05:06 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Issue is RadioButtonMenuItem and CheckBoxMenuItem bullet/checkmark icon is >> not displayed in WindowsL&F when the test is run with NimbusL&F. >> This is because `WindowsIconFactory#VistaMenuItemCheckIcon.paintIcon` called >> `getLaFIcon()` which returns a empty NimbusIcon which causes no icons to be >> drawn. This is because the test after setting WIndows L&F of the menuitem >> reverts back the Windows L&F to Nimbus L&F via >> `UIManager.setLookAndFeel(save);` call in the test so when frame is made >> visible, the L&F resets back to Nimbus L&F resulting in null NimbusIcon. >> >> Fix is made to make sure the whole frame is updated to cater to L&F change >> via `SwingUtilities.updateComponentTreeUI(frame);` call and keep the L&F >> without reverting back to original L&F.. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > unused import Ran the test on Windows platform and it works as expected. ------------- Marked as reviewed by abhiscxk (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25907#pullrequestreview-2994354175
