On Fri, 20 Jun 2025 03:09:32 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

> Issue is RadioButtonMenuItem and CheckBoxMenuItem bullet/checkmark icon is 
> not displayed in WindowsL&F when the test is run with NimbusL&F.
> This is because `WindowsIconFactory#VistaMenuItemCheckIcon.paintIcon` called 
> `getLaFIcon()` which returns a empty NimbusIcon which causes no icons to be 
> drawn. This is because the test after setting WIndows L&F of the menuitem 
> reverts back the Windows L&F to Nimbus L&F via 
> `UIManager.setLookAndFeel(save);` call in the test so when frame is made 
> visible, the L&F resets back to Nimbus L&F resulting in null NimbusIcon.
> 
> Fix is made to make sure the whole frame is updated to cater to L&F change 
> via `SwingUtilities.updateComponentTreeUI(frame);` call and keep the L&F 
> without reverting back to original L&F..

This pull request has now been integrated.

Changeset: 5205eae6
Author:    Prasanta Sadhukhan <psadhuk...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/5205eae6ff28c4587ec4cb659ddffce84f00441b
Stats:     82 lines in 1 file changed: 46 ins; 23 del; 13 mod

8346753: Test 
javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on 
Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not 
visible in Nimbus LookAndFeel

Reviewed-by: abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/25907

Reply via email to