On Wed, 17 Sep 2025 17:26:44 GMT, Daniel Gredler <[email protected]> wrote:

>> You have removed the only override, and the method does nothing with 
>> anything except the provided string.
>> So it seems to me this could be a static utility method, like 
>> isIgnorableWhitespace.
>> I'm not suggesting moving it, just making it static.
>
> I actually wondered about maybe moving this (as static) to `FontUtilities`, 
> next to (and as a sort of companion to) `isIgnorableWhitespace`). Do you 
> think that would be a good change? Or better to just leave it in 
> `RasterPrinterJob` (as static)?

My comment about "not moving it" was meant as a way of saying I'd thought about 
FontUtilities but since it is only used by printing keep it here unless/until 
we find a reason to use it in a wider context.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27345#discussion_r2356541567

Reply via email to