On Thu, 18 Sep 2025 14:56:05 GMT, Daniel Gredler <[email protected]> wrote:
>> When text is printed (or drawn to screen), some whitespace characters like
>> new lines should be ignored (see
>> `FontUtilities.isIgnorableWhitespace(int)`). This is currently not being
>> done when printing on macOS, and is one (of about half a dozen) reasons why
>> `java/awt/print/PrinterJob/PrintTextTest.java` is currently problem listed
>> on macOS. Fixing this bug will get us one step closer to removing this test
>> from the problem list.
>>
>> Within `PrintTextTest`, this issue can be seen specifically with the extra
>> space before and after "drawChars(" on every page of the printed document.
>> This whitespace should not be present.
>>
>> This change aligns behavior with printing on other platforms (see
>> `RasterPrinterJob.removeControlChars(String)`) and with screen display on
>> macOS (see `CCharToGlyphMapper`) and other platforms.
>
> Daniel Gredler has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make removeControlChars() static
Marked as reviewed by serb (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/27345#pullrequestreview-3264995591
