On Fri, 19 Sep 2025 21:53:30 GMT, Phil Race <[email protected]> wrote:

> Moving to open a number of graphics related tests, originally written to test 
> the OpenGL pipeline.
> These versions are "better behaved" than the versions that were in closed - 
> mostly meaning they now
> do things on the right thread and paint properly on demand.
> As a result they now pass - at least on systems with correct drivers etc.
> There are a few bugs to add to the issue list which I'll do right after 
> submitting this.
> 
> I also extended these tests so as to run with the default pipeline on every 
> system, not just OpenGL.
> This mostly went OK except that I found one of the tests fails on macOS with 
> metal.
> I've had to add a new problem listing for that.

LGTM otherwise

test/jdk/sun/java2d/OpenGL/DrawBufImgOp.java line 33:

> 31:  * OpenGL-accelerated destination produces the same results when performed
> 32:  * in software via BufferedImageOp.filter().
> 33:  * @run main/othervm -Dsun.java2d.opengl=True -Dsun.java2d.uiScale=1 
> DrawBufImgOp -ignore

I think since it is failing if we remove `ignore` and since it is mentioned

>  /*
>      * If true, skips tests that are known to trigger bugs (which in
>      * turn may cause crashes, exceptions, or other artifacts).
>      */
> 

my opinion is to remove this param and problemlist this test in failing platform

-------------

Marked as reviewed by psadhukhan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27399#pullrequestreview-3256118610
PR Review Comment: https://git.openjdk.org/jdk/pull/27399#discussion_r2371072535

Reply via email to