On Tue, 23 Sep 2025 04:09:46 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Moving to open a number of graphics related tests, originally written to >> test the OpenGL pipeline. >> These versions are "better behaved" than the versions that were in closed - >> mostly meaning they now >> do things on the right thread and paint properly on demand. >> As a result they now pass - at least on systems with correct drivers etc. >> There are a few bugs to add to the issue list which I'll do right after >> submitting this. >> >> I also extended these tests so as to run with the default pipeline on every >> system, not just OpenGL. >> This mostly went OK except that I found one of the tests fails on macOS with >> metal. >> I've had to add a new problem listing for that. > > test/jdk/sun/java2d/OpenGL/DrawBufImgOp.java line 33: > >> 31: * OpenGL-accelerated destination produces the same results when >> performed >> 32: * in software via BufferedImageOp.filter(). >> 33: * @run main/othervm -Dsun.java2d.opengl=True -Dsun.java2d.uiScale=1 >> DrawBufImgOp -ignore > > I think since it is failing if we remove `ignore` and since it is mentioned > >> /* >> * If true, skips tests that are known to trigger bugs (which in >> * turn may cause crashes, exceptions, or other artifacts). >> */ >> > > my opinion is to remove this param and problemlist this test in failing > platform This is how the test already was. I'm not changing it. I'd be reducing testing if I did this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27399#discussion_r2373048811
