On Tue, 30 Sep 2025 21:04:54 GMT, Damon Nguyen <[email protected]> wrote:
>> Code review https://git.openjdk.org/jdk/pull/27197 for >> [JDK-8367348](https://bugs.openjdk.org/browse/JDK-8367348) made me think how >> to avoid adding more parameters to methods, in particular >> `createInstructionUIPanel`. The `Builder` object captures all the required >> configuration data, it is the `Builder` object that should be used to pass >> the configuration. >> >> This changeset refactors UI creation in `PassFailJFrame`. >> >> * The remaining constructor that accepts positional parameters now creates a >> builder to pass the configuration data. >> * The `createInstructionUIPanel` method now accepts `Builder` instead of a >> set of parameters from it. >> * The `createUI` method with positional parameters has become redundant and >> is removed. Code duplication between two versions of `createUI` is now >> eliminated. >> >> There are no functional differences. I verified it by launching a few tests >> which use `PassFailJFrame` constructors and builder. > > Marked as reviewed by dnguyen (Committer). Thank you @DamonGuy. I still need a *reviewer*. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27321#issuecomment-3386561747
