On Thu, 9 Oct 2025 16:18:14 GMT, Alexey Ivanov <[email protected]> wrote:
>> Marked as reviewed by dnguyen (Committer). > > Thank you @DamonGuy. > > I still need a *reviewer*. > @aivanov-jdk Did I understand it correctly - this changeset prevents multiple > parameters being sent to createInstructionUIPanel() by using the builder > object but there are no changes to how PassFailJFrame is called in the tests > (even when using extra chaining such as .addHyperlinkListener()) ? @honkar-jdk Exactly. I stated in the description: > There are no functional differences. This changeset refactors and unifies the way parameters are passed *internally*. If more parameters are added that are needed in `createUI` or `createInstructionUIPanel` to configure the presentation of instructions, there will be no need to add more positional parameters to `createUI` — you will use the same `Builder` instance that has all the configuration parameters. Thus, all new options will be added to the `Builder` class only. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27321#issuecomment-3389956382
