On Thu, 25 Sep 2025 14:05:11 GMT, Khalid Boulanouare <[email protected]> wrote:
>> Many Mixing tests failed because the work around click lands on the >> minimizing area in the window control and causes the tests to fail. >> >> This fix changes the width of base frames which allows most of tests to pass. > > Khalid Boulanouare has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 66 additional > commits since the last revision: > > - Merge branch 'openjdk:master' into jdk-8158801 > - Merge branch 'openjdk:master' into jdk-8158801 > - Removes uncessary import and adds blank lines between import blocks > - Makes inherited method final > - Removes unnecessary URL > - Fixes a typo > - Removes unncessary boolean variable, line and import > - Merge branch 'openjdk:master' into jdk-8158801 > - Cleans up code for move visibility > - Cleans up code and adds missed import > - ... and 56 more: https://git.openjdk.org/jdk/compare/98b872f3...59a937ac A few more formatting suggestions. test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 97: > 95: > 96: @Override > 97: protected final boolean isMultiFramesTest(){ Suggestion: protected final boolean isMultiFramesTest() { Space between the closing parenthesis and the opening brace. test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 139: > 137: > 138: @Override > 139: protected void cleanup(){ Suggestion: protected void cleanup() { test/jdk/java/awt/Mixing/AWT_Mixing/JPopupMenuOverlapping.java line 69: > 67: frame.setVisible(false); > 68: } > 69: frame = new JFrame("Mixing : Dropdown Overlapping test"); Should the old frame be disposed of instead of just hidden? Is it even possible that `frame` is not `null`? test/jdk/java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java line 65: > 63: } > 64: private String testSeq; > 65: private final static String checkSeq = "010000101"; Suggestion: private static final String checkSeq = "010000101"; Sort modifiers? (Not required.) ------------- Changes requested by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25971#pullrequestreview-3568531235 PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2611453185 PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2611461395 PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2611646793 PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2611674866
