On Thu, 11 Dec 2025 17:27:34 GMT, Alexey Ivanov <[email protected]> wrote:
>> Khalid Boulanouare has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 66 >> additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into jdk-8158801 >> - Merge branch 'openjdk:master' into jdk-8158801 >> - Removes uncessary import and adds blank lines between import blocks >> - Makes inherited method final >> - Removes unnecessary URL >> - Fixes a typo >> - Removes unncessary boolean variable, line and import >> - Merge branch 'openjdk:master' into jdk-8158801 >> - Cleans up code for move visibility >> - Cleans up code and adds missed import >> - ... and 56 more: https://git.openjdk.org/jdk/compare/d5a7c439...59a937ac > > test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 97: > >> 95: >> 96: @Override >> 97: protected final boolean isMultiFramesTest(){ > > Suggestion: > > protected final boolean isMultiFramesTest() { > > Space between the closing parenthesis and the opening brace. Done! > test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line > 139: > >> 137: >> 138: @Override >> 139: protected void cleanup(){ > > Suggestion: > > protected void cleanup() { Done. > test/jdk/java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java line 65: > >> 63: } >> 64: private String testSeq; >> 65: private final static String checkSeq = "010000101"; > > Suggestion: > > private static final String checkSeq = "010000101"; > > Sort modifiers? (Not required.) Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2614608912 PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2614607956 PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2614609912
