On Wed, 10 Dec 2025 20:02:34 GMT, Damon Nguyen <[email protected]> wrote:
>> There was a prior PR that attempted to fix this issue, but it was found that >> [JDK-8280987](https://bugs.openjdk.org/browse/JDK-8280987) was the more >> reasonable cause. The issue was caused by Ubuntu instances having a large >> amount of graphics configurations, hence a large amount of concurrent frames >> being open and tested on at a time. As such, the newly suggested fix was to >> instead break apart the test into batches. >> >> This change creates and disposes of the test frames in batches of 20, up to >> the number of GC's identified. The original problem was recreated when >> testing on Ubuntu 24.04, and I have re-tested this with the updated test on >> the same device, and it passes. When debugging, 140 GC's were identified and >> all 140 frames were created and disposed of. Also tested this on macOS 15 >> and the test also passes. CI looks good as well. > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Space out batches of frames test/jdk/java/awt/Frame/FrameVisualTest.java line 67: > 65: System.out.println("frames.length: " + frames.length); > 66: > 67: // Iterate through gcs in batches of 20 maybe we could have a var for this ? Perhaps even allow it to be set as a program arg even if you default to 20. Also wouldn't one at a time be the most stable ? Finally, is it even necessary to test ALL of them ? Isn't it sufficient to test 30-40 and call it a day ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28646#discussion_r2612141387
